Initial fixes to generate_gdd20_baseline #3543
Merged
+168
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te_gdd20_baseline().
samsrabin
added
bug
samsrabin
removed
the
next
samsrabin
added
next
github-project-automation
bot
moved this to Ready to start (or start again)
in CTSM: Upcoming tags
samsrabin
moved this from Ready to start (or start again)
to In progress - b4b-dev
in CTSM: Upcoming tags
samsrabin
removed
the
next
samsrabin
changed the title
slevis-lmwg
approved these changes
Jan 9, 2026
Contributor
slevis-lmwg
left a comment
slevis-lmwg
left a comment
There was a problem hiding this comment.
@samsrabin thank you for going over this work with me.
github-project-automation
bot
moved this from In progress - b4b-dev
to In progress - master
in CTSM: Upcoming tags
ekluzek
moved this from In progress - master
to In progress - b4b-dev
in CTSM: Upcoming tags
samsrabin
added
PR status: needs testing
and removed
PR status: awaiting review
github-project-automation
bot
moved this from In progress - b4b-dev
to Done (non release/external)
in CTSM: Upcoming tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Some Python changes needed to get the
generate_gdd20_baselinescript working, along with some tests to prevent those exact problems from happening again. We should also add a SystemTest, but I've filed that as a separate issue: #3542.Note that more changes are coming. This PR is the first of several that will bring this script and related scripts up to date with the versions I used during the crop reparameterization, which have a complete set of fixes.
Note to reviewer: It'd probably be best to walk through the commits one-by-one.
Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed (include github issue #): None
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
I've listed expectations for these suites, but if any fail, I will add them to the expected failure list. This is acceptable because I have more PRs to come in this series that will eventually fix the tests, if needed.
clm_pymodssuite completes successfully (diffs okay in tests exercising affected scripts but none occurred). No unexpected failures.rxcropmaturitysuite completes successfully (no baseline for comparison). No unexpected failures.